lkml.org 
[lkml]   [2014]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 1/1] SCSI-libfc: Deletion of an unnecessary check before the function call "fc_fcp_ddp_done"
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Thu, 20 Nov 2014 20:10:19 +0100

    The fc_fcp_ddp_done() function tests whether its argument is NULL and then
    returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/scsi/libfc/fc_exch.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/scsi/libfc/fc_exch.c b/drivers/scsi/libfc/fc_exch.c
    index 1b3a094..aad6f48 100644
    --- a/drivers/scsi/libfc/fc_exch.c
    +++ b/drivers/scsi/libfc/fc_exch.c
    @@ -2120,8 +2120,7 @@ static struct fc_seq *fc_exch_seq_send(struct fc_lport *lport,
    spin_unlock_bh(&ep->ex_lock);
    return sp;
    err:
    - if (fsp)
    - fc_fcp_ddp_done(fsp);
    + fc_fcp_ddp_done(fsp);
    rc = fc_exch_done_locked(ep);
    spin_unlock_bh(&ep->ex_lock);
    if (!rc)
    --
    2.1.3


    \
     
     \ /
      Last update: 2014-11-20 21:01    [W:4.016 / U:0.644 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site