Messages in this thread Patch in this message | | | Date | Thu, 20 Nov 2014 17:47:29 +0100 | From | SF Markus Elfring <> | Subject | [PATCH 1/1] PCI: hotplug: Deletion of an unnecessary check before the function call "pci_dev_put" |
| |
From: Markus Elfring <elfring@users.sourceforge.net> Date: Thu, 20 Nov 2014 17:42:23 +0100
The pci_dev_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/pci/hotplug/cpci_hotplug_core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/pci/hotplug/cpci_hotplug_core.c b/drivers/pci/hotplug/cpci_hotplug_core.c index e09cf78..82c969b 100644 --- a/drivers/pci/hotplug/cpci_hotplug_core.c +++ b/drivers/pci/hotplug/cpci_hotplug_core.c @@ -211,8 +211,7 @@ static void release_slot(struct hotplug_slot *hotplug_slot) kfree(slot->hotplug_slot->info); kfree(slot->hotplug_slot); - if (slot->dev) - pci_dev_put(slot->dev); + pci_dev_put(slot->dev); kfree(slot); } -- 2.1.3
| |