lkml.org 
[lkml]   [2014]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 00/33] thermal: exynos: convert the driver to use per-SoC type operations
Hi Eduardo,

> Hi,
>
> This patch series replaces the hardware registers abstractions in
> the Exynos thermal driver by the usage of per-SoC type operations.
> Such solution provides simpler, easier to understand code and
> allows removal of ~250 LOCs (~11% of the whole source code) from
> the driver. Some other driver improvements are now also possible
> thanks to these changes but are scheduled at later time (like
> consolidating code for clearing IRQs using INTCLEAR register).
>
> The patchset should not cause any functionality changes. This
> means that unless there are some bugs in the patches itself there
> should be no behavior changes for the driver (this also includes
> lack of changes in the way hardware is accessed by the driver).
>
> All testing was done on (Exynos4412 SoC based) ODROID U3 board
> (some additional patches are needed to make the Exynos thermal
> driver work on this hardware).

For the whole patch series:

Repository:
kernel_linux-soc-thermal/next
SHA1: 4027494124fd88e5d51127eebba315de5d8d57c8

Test HW:

Trats2 - Exynos4412
Tested-by: Lukasz Majewski <l.majewski@samsung.com>

Trats - Exynos4210
Tested-by: Lukasz Majewski <l.majewski@samsung.com>

ARNDALE(SMDK) - Exynos5250
Tested-by: Lukasz Majewski <l.majewski@samsung.com>

ARNDALE OCTA - Exynos5420
Tested-by: Lukasz Majewski <l.majewski@samsung.com>


>
> Depends on:
> - 'next' branch of linux-soc-thermal.git kernel tree from Eduardo
>
> Changes since v1 (https://lkml.org/lkml/2014/9/18/305):
> - rebased on top of the current linux-soc-thermal kernel
>
> Best regards,
> --
> Bartlomiej Zolnierkiewicz
> Samsung R&D Institute Poland
> Samsung Electronics
>
>
> Bartlomiej Zolnierkiewicz (33):
> thermal: exynos: remove needless triminfo_data abstraction
> thermal: exynos: remove needless tmu_status abstraction
> thermal: exynos: remove needless threshold_temp abstraction
> thermal: exynos: remove needless triminfo_ctrl abstraction
> thermal: exynos: remove needless test_mux_addr_shift abstraction
> thermal: exynos: remove needless therm_trip_[mode,mask]_shift
> abstractions
> thermal: exynos: remove needless therm_trip_en_shift abstraction
> thermal: exynos: remove needless emul_temp_shift abstraction
> thermal: exynos: remove needless emul_time_shift abstraction
> thermal: exynos: replace tmu_irqstatus check by Exynos5440 one
> thermal: exynos: replace tmu_pmin check by Exynos5440 one
> thermal: exynos: simplify HW_TRIP level setting
> thermal: exynos: replace threshold_falling check by Exynos SoC type
> one
> thermal: exynos: remove TMU_SUPPORT_READY_STATUS flag
> thermal: exynos: remove TMU_SUPPORT_TRIM_RELOAD flag
> thermal: exynos: add sanitize_temp_error() helper
> thermal: exynos: add get_th_reg() helper
> thermal: exynos: add ->tmu_initialize method
> thermal: exynos: add get_con_reg() helper
> thermal: exynos: add ->tmu_control method
> thermal: exynos: add ->tmu_read method
> thermal: exynos: add get_emul_con_reg() helper
> thermal: exynos: add ->tmu_set_emulation method
> thermal: exynos: add ->tmu_clear_irqs method
> thermal: exynos: remove TMU_SUPPORT_FALLING_TRIP flag
> thermal: exynos: remove TMU_SUPPORT_EMUL_TIME flag
> thermal: exynos: remove TMU_SUPPORT_EMULATION flag
> thermal: exynos: remove TMU_SUPPORT_ADDRESS_MULTIPLE flag
> thermal: exynos: remove TMU_SUPPORT_MULTI_INST flag
> thermal: exynos: remove test_mux pdata field
> thermal: exynos: remove SoC type ifdefs
> thermal: exynos: remove __EXYNOS5420_TMU_DATA macro
> thermal: exynos: remove exynos_tmu_data.h include
>
> drivers/thermal/samsung/exynos_thermal_common.h | 1 -
> drivers/thermal/samsung/exynos_tmu.c | 692
> ++++++++++++++++--------
> drivers/thermal/samsung/exynos_tmu.h | 123 +----
> drivers/thermal/samsung/exynos_tmu_data.c | 239 +-------
> drivers/thermal/samsung/exynos_tmu_data.h | 159 ------ 5 files
> changed, 485 insertions(+), 729 deletions(-) delete mode 100644
> drivers/thermal/samsung/exynos_tmu_data.h
>



--
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group


\
 
 \ /
  Last update: 2014-11-20 13:21    [W:0.909 / U:0.328 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site