lkml.org 
[lkml]   [2014]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 1/1] kconfig: Deletion of unnecessary checks before the function call "sym_calc_value"
    The sym_calc_value() function tests whether its argument is NULL and then
    returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    scripts/kconfig/confdata.c | 6 ++----
    scripts/kconfig/symbol.c | 3 +--
    2 files changed, 3 insertions(+), 6 deletions(-)

    diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c
    index f88d90f..3073cb6 100644
    --- a/scripts/kconfig/confdata.c
    +++ b/scripts/kconfig/confdata.c
    @@ -262,8 +262,7 @@ int conf_read_simple(const char *name, int def)
    goto load;
    sym_add_change_count(1);
    if (!sym_defconfig_list) {
    - if (modules_sym)
    - sym_calc_value(modules_sym);
    + sym_calc_value(modules_sym);
    return 1;
    }

    @@ -399,8 +398,7 @@ setsym:
    free(line);
    fclose(in);

    - if (modules_sym)
    - sym_calc_value(modules_sym);
    + sym_calc_value(modules_sym);
    return 0;
    }

    diff --git a/scripts/kconfig/symbol.c b/scripts/kconfig/symbol.c
    index 7caabdb..3f7797b 100644
    --- a/scripts/kconfig/symbol.c
    +++ b/scripts/kconfig/symbol.c
    @@ -447,8 +447,7 @@ void sym_clear_all_valid(void)
    for_all_symbols(i, sym)
    sym->flags &= ~SYMBOL_VALID;
    sym_add_change_count(1);
    - if (modules_sym)
    - sym_calc_value(modules_sym);
    + sym_calc_value(modules_sym);
    }

    void sym_set_changed(struct symbol *sym)
    --
    2.1.3



    \
     
     \ /
      Last update: 2014-11-02 21:01    [W:4.019 / U:0.084 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site