lkml.org 
[lkml]   [2014]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.14 029/122] ALSA: usb-audio: Fix memory leak in FTU quirk
    Date
    3.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Takashi Iwai <tiwai@suse.de>

    commit 1a290581ded60e87276741f8ca97b161d2b226fc upstream.

    M-audio FastTrack Ultra quirk doesn't release the kzalloc'ed memory.
    This patch adds the private_free callback to release it properly.

    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    sound/usb/mixer_quirks.c | 6 ++++++
    1 file changed, 6 insertions(+)

    --- a/sound/usb/mixer_quirks.c
    +++ b/sound/usb/mixer_quirks.c
    @@ -885,6 +885,11 @@ static int snd_ftu_eff_switch_put(struct
    return changed;
    }

    +static void kctl_private_value_free(struct snd_kcontrol *kctl)
    +{
    + kfree((void *)kctl->private_value);
    +}
    +
    static int snd_ftu_create_effect_switch(struct usb_mixer_interface *mixer,
    int validx, int bUnitID)
    {
    @@ -919,6 +924,7 @@ static int snd_ftu_create_effect_switch(
    return -ENOMEM;
    }

    + kctl->private_free = kctl_private_value_free;
    err = snd_ctl_add(mixer->chip->card, kctl);
    if (err < 0)
    return err;



    \
     
     \ /
      Last update: 2014-11-19 23:41    [W:2.421 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site