lkml.org 
[lkml]   [2014]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 1/1] bcache: Deletion of an unnecessary check before the function call "kobject_put"
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Wed, 19 Nov 2014 21:25:39 +0100

    The kobject_put() function tests whether its argument is NULL and then
    returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/md/bcache/super.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
    index d4713d0..1443c55 100644
    --- a/drivers/md/bcache/super.c
    +++ b/drivers/md/bcache/super.c
    @@ -2076,8 +2076,7 @@ static void bcache_exit(void)
    {
    bch_debug_exit();
    bch_request_exit();
    - if (bcache_kobj)
    - kobject_put(bcache_kobj);
    + kobject_put(bcache_kobj);
    if (bcache_wq)
    destroy_workqueue(bcache_wq);
    if (bcache_major)
    --
    2.1.3


    \
     
     \ /
      Last update: 2014-11-19 21:41    [W:4.501 / U:1.612 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site