lkml.org 
[lkml]   [2014]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 1/1] mISDN: Deletion of unnecessary checks before the function call "vfree"
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Wed, 19 Nov 2014 20:48:26 +0100

    The vfree() function performs also input parameter validation. Thus the test
    around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/isdn/mISDN/l1oip_codec.c | 6 ++----
    1 file changed, 2 insertions(+), 4 deletions(-)

    diff --git a/drivers/isdn/mISDN/l1oip_codec.c b/drivers/isdn/mISDN/l1oip_codec.c
    index a601c84..9b033be 100644
    --- a/drivers/isdn/mISDN/l1oip_codec.c
    +++ b/drivers/isdn/mISDN/l1oip_codec.c
    @@ -312,10 +312,8 @@ l1oip_ulaw_to_alaw(u8 *data, int len, u8 *result)
    void
    l1oip_4bit_free(void)
    {
    - if (table_dec)
    - vfree(table_dec);
    - if (table_com)
    - vfree(table_com);
    + vfree(table_dec);
    + vfree(table_com);
    table_com = NULL;
    table_dec = NULL;
    }
    --
    2.1.3


    \
     
     \ /
      Last update: 2014-11-19 21:21    [W:4.021 / U:0.232 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site