lkml.org 
[lkml]   [2014]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 1/1] DRM-UDL: Deletion of an unnecessary check before the function call "vunmap"
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Wed, 19 Nov 2014 17:33:32 +0100

    The vunmap() function performes also input parameter validation. Thus the test
    around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/gpu/drm/udl/udl_gem.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/gpu/drm/udl/udl_gem.c b/drivers/gpu/drm/udl/udl_gem.c
    index 8044f5f..2979625 100644
    --- a/drivers/gpu/drm/udl/udl_gem.c
    +++ b/drivers/gpu/drm/udl/udl_gem.c
    @@ -164,8 +164,7 @@ void udl_gem_vunmap(struct udl_gem_object *obj)
    return;
    }

    - if (obj->vmapping)
    - vunmap(obj->vmapping);
    + vunmap(obj->vmapping);

    udl_gem_put_pages(obj);
    }
    --
    2.1.3


    \
     
     \ /
      Last update: 2014-11-19 18:21    [W:4.119 / U:0.300 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site