lkml.org 
[lkml]   [2014]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 1/1] PM-wakeup: Deletion of an unnecessary check before the function call "wakeup_source_unregister"
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Wed, 19 Nov 2014 12:21:24 +0100

    The wakeup_source_unregister() function tests whether its argument is NULL
    and then returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/base/power/wakeup.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/base/power/wakeup.c b/drivers/base/power/wakeup.c
    index eb1bd2e..87dfc1d 100644
    --- a/drivers/base/power/wakeup.c
    +++ b/drivers/base/power/wakeup.c
    @@ -267,8 +267,7 @@ int device_wakeup_disable(struct device *dev)
    return -EINVAL;

    ws = device_wakeup_detach(dev);
    - if (ws)
    - wakeup_source_unregister(ws);
    + wakeup_source_unregister(ws);

    return 0;
    }
    --
    2.1.3


    \
     
     \ /
      Last update: 2014-11-19 12:41    [W:4.016 / U:0.264 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site