lkml.org 
[lkml]   [2014]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 1/1] firmware class: Deletion of an unnecessary check before the function call "vunmap"
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Wed, 19 Nov 2014 11:38:38 +0100

    The vunmap() function performes also input parameter validation. Thus the test
    around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/base/firmware_class.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c
    index 3d785eb..532662c 100644
    --- a/drivers/base/firmware_class.c
    +++ b/drivers/base/firmware_class.c
    @@ -591,8 +591,7 @@ static int fw_map_pages_buf(struct firmware_buf *buf)
    if (!buf->is_paged_buf)
    return 0;

    - if (buf->data)
    - vunmap(buf->data);
    + vunmap(buf->data);
    buf->data = vmap(buf->pages, buf->nr_pages, 0, PAGE_KERNEL_RO);
    if (!buf->data)
    return -ENOMEM;
    --
    2.1.3


    \
     
     \ /
      Last update: 2014-11-19 12:01    [W:4.068 / U:0.240 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site