Messages in this thread | | | Date | Wed, 19 Nov 2014 09:34:45 +0000 | From | Mark Brown <> | Subject | Re: [PATCH v2 1/4] spi: Add 'last' flag to spi_transfer structure |
| |
On Tue, Nov 18, 2014 at 11:55:46PM +0100, Beniamino Galvani wrote:
> Would it be better to introduce something like:
> static inline bool > spi_transfer_is_last(struct spi_master *master, struct spi_transfer *xfer) > { > return list_is_last(&xfer->transfer_list, &master->cur_msg->transfers); > }
> or open code it in the driver?
Adding the helper function seems better, it means we can change the implementation later. [unhandled content-type:application/pgp-signature] | |