lkml.org 
[lkml]   [2014]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 1/1] DRM-vmwgfx: Deletion of an unnecessary check before the function call "vfree"
    On November 19, 2014 5:57:13 PM SF Markus Elfring 
    <elfring@users.sourceforge.net> wrote:
    > From: Markus Elfring <elfring@users.sourceforge.net>
    > Date: Wed, 19 Nov 2014 17:50:19 +0100
    >
    > The vfree() function performes also input parameter validation. Thus the test
    > around the call is not needed.
    >
    > This issue was detected by using the Coccinelle software.
    >
    > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    > ---
    > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 3 +--
    > 1 file changed, 1 insertion(+), 2 deletions(-)
    >
    > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c
    > b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c
    > index 14b2f50..f9a67b8 100644
    > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c
    > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c
    > @@ -889,8 +889,7 @@ static int vmw_driver_unload(struct drm_device *dev)
    >
    > if (dev_priv->ctx.res_ht_initialized)
    > drm_ht_remove(&dev_priv->ctx.res_ht);
    > - if (dev_priv->ctx.cmd_bounce)
    > - vfree(dev_priv->ctx.cmd_bounce);
    > + vfree(dev_priv->ctx.cmd_bounce);
    > if (dev_priv->enable_fb) {
    > vmw_fb_close(dev_priv);
    > vmw_kms_restore_vga(dev_priv);

    Reviewed-by: Thierry Reding <thierry.reding@gmail.com>




    \
     
     \ /
      Last update: 2014-11-20 06:01    [W:4.016 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site