Messages in this thread | | | Date | Wed, 19 Nov 2014 10:14:36 +0100 | From | Cornelia Huck <> | Subject | Re: [PATCH net] virtio-net: validate features during probe |
| |
On Wed, 19 Nov 2014 10:59:39 +0200 "Michael S. Tsirkin" <mst@redhat.com> wrote:
> +bool __virtnet_fail_on_feature(struct virtio_device *vdev, unsigned int fbit, > + const char *fname) > +{ > + if (!virtio_has_feature(vdev, fbit)) > + return false; > + > + dev_err(&dev->dev, "missing requirements for feature bit %d: %s\n", > + fbit, fname);
I'd like the message to point out that this is a hypervisor problem: I can imagine that a user would be stumped about what to do about this. And printing what requirements are missing would probably be helpful to someone trying to fix the hypervisor.
> + > + return true; > +} > + >
| |