lkml.org 
[lkml]   [2014]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 1/1] DRM-tilcdc: Deletion of an unnecessary check before the function call "drm_fbdev_cma_hotplug_event"
    On November 19, 2014 5:28:59 PM SF Markus Elfring 
    <elfring@users.sourceforge.net> wrote:
    > From: Markus Elfring <elfring@users.sourceforge.net>
    > Date: Wed, 19 Nov 2014 17:05:20 +0100
    >
    > The drm_fbdev_cma_hotplug_event() function tests whether its argument is NULL
    > and then returns immediately. Thus the test around the call is not needed.
    >
    > This issue was detected by using the Coccinelle software.
    >
    > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    > ---
    > drivers/gpu/drm/tilcdc/tilcdc_drv.c | 3 +--
    > 1 file changed, 1 insertion(+), 2 deletions(-)
    >
    > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
    > b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
    > index 000428e..335b1dc 100644
    > --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
    > +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
    > @@ -58,8 +58,7 @@ static struct drm_framebuffer *tilcdc_fb_create(struct
    > drm_device *dev,
    > static void tilcdc_fb_output_poll_changed(struct drm_device *dev)
    > {
    > struct tilcdc_drm_private *priv = dev->dev_private;
    > - if (priv->fbdev)
    > - drm_fbdev_cma_hotplug_event(priv->fbdev);
    > + drm_fbdev_cma_hotplug_event(priv->fbdev);
    > }
    >
    > static const struct drm_mode_config_funcs mode_config_funcs = {

    Reviewed-by: Thierry Reding <thierry.reding@gmail.com>




    \
     
     \ /
      Last update: 2014-11-20 05:41    [W:6.029 / U:1.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site