Messages in this thread | | | From | Andy Lutomirski <> | Date | Wed, 19 Nov 2014 17:11:56 -0800 | Subject | Re: [PATCH v3 3/3] sched, x86: Check that we're on the right stack in schedule and __might_sleep |
| |
On Wed, Nov 19, 2014 at 5:09 PM, Linus Torvalds <torvalds@linux-foundation.org> wrote: > On Wed, Nov 19, 2014 at 4:46 PM, Andy Lutomirski <luto@amacapital.net> wrote: >> >> I'm very hesitant to use irq_enter for this, though. I think we want >> just the irq_count part. > > Oh, I agree. I mentioned irq_enter/exit() just as the place the > preempt count increment normally happens. I have nothing against doing > it manually for these things that really aren't normal interrupts. >
It may need to be considerably more complicated to keep RCU happy, though. In fact, I think that this code is already wrong.
I'll write something and cc Paul to get some feedback.
--Andy
| |