lkml.org 
[lkml]   [2014]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 7/9] staging: panel: Refactor LCD init code
    On Tue, Nov 18, 2014 at 09:56:12PM +0100, Mariusz Gorski wrote:
    > Rework lcd_init method to make it a little bit more clear about
    > the precedence of the params, move LCD geometry and pins layout
    > to the LCD struct and thus make the LCD-related module params
    > effectively read-only.
    >
    > Signed-off-by: Mariusz Gorski <marius.gorski@gmail.com>

    Acked-by: Willy Tarreau <w@1wt.eu>

    I like this refactoring. However I don't know if you got your LCD module
    to work or not, but for such important changes you should definitely test
    the code, since it's very easy to introduce minor bugs or even to fix a
    bug that used to make the whole driver work...

    Willy



    \
     
     \ /
      Last update: 2014-11-18 23:01    [W:4.277 / U:0.672 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site