lkml.org 
[lkml]   [2014]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 1/1] net: sched: Deletion of an unnecessary check before the function call "kfree"
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Tue, 18 Nov 2014 21:21:16 +0100

    The kfree() function tests whether its argument is NULL and then
    returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    net/sched/cls_bpf.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/net/sched/cls_bpf.c b/net/sched/cls_bpf.c
    index 0e30d58..f323944 100644
    --- a/net/sched/cls_bpf.c
    +++ b/net/sched/cls_bpf.c
    @@ -212,8 +212,7 @@ static int cls_bpf_modify_existing(struct net *net, struct tcf_proto *tp,

    if (fp_old)
    bpf_prog_destroy(fp_old);
    - if (bpf_old)
    - kfree(bpf_old);
    + kfree(bpf_old);

    return 0;

    --
    2.1.3


    \
     
     \ /
      Last update: 2014-11-18 22:01    [W:4.017 / U:0.988 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site