lkml.org 
[lkml]   [2014]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.12 010/206] vxlan: fix a free after use
    Date
    From: Li RongQing <roy.qing.li@gmail.com>

    3.12-stable review patch. If anyone has any objections, please let me know.

    ===============

    [ Upstream commit 7a9f526fc3ee49b6034af2f243676ee0a27dcaa8 ]

    pskb_may_pull maybe change skb->data and make eth pointer oboslete,
    so eth needs to reload

    Fixes: 91269e390d062 ("vxlan: using pskb_may_pull as early as possible")
    Cc: Eric Dumazet <edumazet@google.com>
    Signed-off-by: Li RongQing <roy.qing.li@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    ---
    drivers/net/vxlan.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
    index aff1694d2d9e..23969eaf88c1 100644
    --- a/drivers/net/vxlan.c
    +++ b/drivers/net/vxlan.c
    @@ -1897,6 +1897,7 @@ static netdev_tx_t vxlan_xmit(struct sk_buff *skb, struct net_device *dev)
    msg->icmph.icmp6_type == NDISC_NEIGHBOUR_SOLICITATION)
    return neigh_reduce(dev, skb);
    }
    + eth = eth_hdr(skb);
    #endif
    }

    --
    2.1.3


    \
     
     \ /
      Last update: 2014-11-18 17:01    [W:4.218 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site