lkml.org 
[lkml]   [2014]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 06/12] media: marvell-ccic: use vb2_ops_wait_prepare/finish helper
    On Tue, 18 Nov 2014 11:23:35 +0000
    "Lad, Prabhakar" <prabhakar.csengg@gmail.com> wrote:

    > drivers/media/platform/marvell-ccic/mcam-core.c | 29 +++++--------------------
    > 1 file changed, 5 insertions(+), 24 deletions(-)

    So I'm not convinced that this patch improves things; it moves a tiny bit
    of code into another file where anybody reading the driver will have to
    go look to see what's going on. But I guess it doesn't really make
    things worse either; I won't try to stand in its way. It would be nice
    to see a real changelog on the patch, though.

    jon


    \
     
     \ /
      Last update: 2014-11-18 14:41    [W:2.670 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site