Messages in this thread | | | Date | Tue, 18 Nov 2014 08:03:17 -0500 | From | Jonathan Corbet <> | Subject | Re: [PATCH 06/12] media: marvell-ccic: use vb2_ops_wait_prepare/finish helper |
| |
On Tue, 18 Nov 2014 11:23:35 +0000 "Lad, Prabhakar" <prabhakar.csengg@gmail.com> wrote:
> drivers/media/platform/marvell-ccic/mcam-core.c | 29 +++++-------------------- > 1 file changed, 5 insertions(+), 24 deletions(-)
So I'm not convinced that this patch improves things; it moves a tiny bit of code into another file where anybody reading the driver will have to go look to see what's going on. But I guess it doesn't really make things worse either; I won't try to stand in its way. It would be nice to see a real changelog on the patch, though.
jon
| |