lkml.org 
[lkml]   [2014]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 1/1] fs-namespace: Deletion of unnecessary checks before the function call "mntput"
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Tue, 18 Nov 2014 12:10:43 +0100

    The mntput() function tests whether its argument is NULL and then
    returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    fs/namespace.c | 6 ++----
    1 file changed, 2 insertions(+), 4 deletions(-)

    diff --git a/fs/namespace.c b/fs/namespace.c
    index 550dbff..3b3710e 100644
    --- a/fs/namespace.c
    +++ b/fs/namespace.c
    @@ -2615,10 +2615,8 @@ struct mnt_namespace *copy_mnt_ns(unsigned long flags, struct mnt_namespace *ns,
    }
    namespace_unlock();

    - if (rootmnt)
    - mntput(rootmnt);
    - if (pwdmnt)
    - mntput(pwdmnt);
    + mntput(rootmnt);
    + mntput(pwdmnt);

    return new_ns;
    }
    --
    2.1.3


    \
     
     \ /
      Last update: 2014-11-18 13:01    [W:4.075 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site