Messages in this thread | | | From | Stephan Mueller <> | Subject | Re: [PATCH v2 06/10] crypto: AF_ALG: make setkey optional | Date | Wed, 19 Nov 2014 03:36:45 +0100 |
| |
Am Dienstag, 18. November 2014, 22:10:13 schrieb Herbert Xu:
Hi Herbert,
> On Sun, Nov 16, 2014 at 03:26:58AM +0100, Stephan Mueller wrote: > > The current AF_ALG implementation requires that a userspace interface > > implementation must provide a callback for setkey. Such a call is not > > appliable to random number generators. > > > > To prepare AF_ALG for the addition of a random number generator user > > space interface, this function callback invocation is made optional. > > > > Signed-off-by: Stephan Mueller <smueller@chronox.de> > > Did you actually try this? AFAICS setkey is already optional.
You are correct. I tested the kernel without my patch and the setkey on the RNG handle is rejected. I now also see the check already present in the alg_setkey function.
This patch will be removed from a new patchset. > > Cheers,
-- Ciao Stephan
| |