lkml.org 
[lkml]   [2014]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 20/26 v5] seq_buf: Add seq_buf_can_fit() helper function
From
Date
On Mon, 2014-11-17 at 19:56 -0500, Steven Rostedt wrote:
> On Mon, 17 Nov 2014 16:35:32 -0800
> Joe Perches <joe@perches.com> wrote:
>
>
> > What "logic" does it place in one place and
> > how does it matter?
>
> Look at the next patch.

I don't have it and you are not cc'ing me.
I think you are getting carried away with the helpers.

> > I don't see it making mistakes more or less
> > likely, I just see it being used to avoid
> > setting the overflow state which seems like
> > more of an error than anything else.
> >
> > Why avoid setting overflow at all?
[]
> It has nothing to do with overflow. Where did you get that from?

writing to seq_buf really only cares about overflow.

seq_buf -> write to buffer -> overflowed?
expand buffer, redo everything else when finished,
dump buffer



\
 
 \ /
  Last update: 2014-11-18 02:41    [W:0.915 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site