Messages in this thread | | | Date | Tue, 18 Nov 2014 02:11:21 +0200 | From | Mikko Perttunen <> | Subject | Re: [PATCHv2 1/1] thermal: of: improve of-thermal sensor registration API |
| |
On 11/18/2014 12:44 AM, Eduardo Valentin wrote: > Different drivers request API extensions in of-thermal. For this reason, > additional callbacks are required to fit the new drivers needs. > > The current API implementation expects the registering sensor driver > to provide a get_temp and get_trend callbacks as function parameters. > As the amount of callbacks is growing, this patch changes the existing > implementation to use a .ops field to hold all the of thermal callbacks > to sensor drivers. > > This patch also changes the existing of-thermal users to fit the new > API design. No functional change is introduced in this patch. > > Cc: Alexandre Courbot <gnurou@gmail.com> > Cc: devicetree@vger.kernel.org > Cc: Grant Likely <grant.likely@linaro.org> > Cc: Guenter Roeck <linux@roeck-us.net> > Cc: Jean Delvare <jdelvare@suse.de> > Cc: linux-kernel@vger.kernel.org > Cc: linux-pm@vger.kernel.org > Cc: linux-tegra@vger.kernel.org > Cc: lm-sensors@lm-sensors.org > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Stephen Warren <swarren@wwwdotorg.org> > Cc: Thierry Reding <thierry.reding@gmail.com> > Cc: Zhang Rui <rui.zhang@intel.com> > Signed-off-by: Eduardo Valentin <edubezval@gmail.com> > --- > > Difference from V1: > - Fix error handling when .get_trend is not provided. > > --- > drivers/hwmon/lm75.c | 9 +++-- > drivers/hwmon/ntc_thermistor.c | 6 +++- > drivers/hwmon/tmp102.c | 6 +++- > drivers/thermal/of-thermal.c | 41 +++++++++------------- > drivers/thermal/tegra_soctherm.c | 7 ++-- > drivers/thermal/ti-soc-thermal/ti-thermal-common.c | 8 +++-- > include/linux/thermal.h | 24 +++++++++---- > 7 files changed, 62 insertions(+), 39 deletions(-) > > ... > diff --git a/drivers/thermal/tegra_soctherm.c b/drivers/thermal/tegra_soctherm.c > index 70f7e9e..893c39c 100644 > --- a/drivers/thermal/tegra_soctherm.c > +++ b/drivers/thermal/tegra_soctherm.c > @@ -317,6 +317,10 @@ static int tegra_thermctl_get_temp(void *data, long *out_temp) > return 0; > } > > +static const struct thermal_zone_of_device_ops tegra_of_thermal_ops = { > + .get_trend = tegra_thermctl_get_temp, > +};
This should probably read ".get_temp = tegra_thermctl_get_temp" instead of .get_trend :)
> ...
Cheers, Mikko
| |