lkml.org 
[lkml]   [2014]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 2/8] perf, tools: Add --branch-history option to report
Date
On Wed, 12 Nov 2014 01:05:05 +0100, Andi Kleen wrote:
>> And please also add a new CCKEY_SRCLINE if you print srcline with the
>> callchains so that users can give "-g srcline" if they want (regardless
>> of the branch history feature).
>
> That would be largely identical to CCKEY_ADDRESS
> except for the case of two calls to the same function from
> the same line. Probably not worth adding?

For sorting, yes, it'd be almost identical. But what I'm saying is for
printing - IOW print callchain entries with symbol and srcline (for
normal perf report too).

Anyway, I think it'd be a separate patch(set).

Thanks,
Namhyung


\
 
 \ /
  Last update: 2014-11-17 08:01    [W:0.074 / U:1.900 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site