Messages in this thread | | | From | Namhyung Kim <> | Subject | Re: [PATCH 2/8] perf, tools: Add --branch-history option to report | Date | Mon, 17 Nov 2014 15:31:57 +0900 |
| |
On Wed, 12 Nov 2014 01:05:05 +0100, Andi Kleen wrote: >> And please also add a new CCKEY_SRCLINE if you print srcline with the >> callchains so that users can give "-g srcline" if they want (regardless >> of the branch history feature). > > That would be largely identical to CCKEY_ADDRESS > except for the case of two calls to the same function from > the same line. Probably not worth adding?
For sorting, yes, it'd be almost identical. But what I'm saying is for printing - IOW print callchain entries with symbol and srcline (for normal perf report too).
Anyway, I think it'd be a separate patch(set).
Thanks, Namhyung
| |