Messages in this thread | | | From | Namhyung Kim <> | Subject | Re: [PATCH V2 2/3] perf tool:perf diff support for different binaries | Date | Mon, 17 Nov 2014 14:09:33 +0900 |
| |
On Mon, 10 Nov 2014 16:01:19 -0500, kan liang wrote: > From: Kan Liang <kan.liang@intel.com> > > Currently, the perf diff only works with same binaries. That's because > it compares the symbol start address. It doesn't work if the perf.data > comes from different binaries. This patch matches the function names. > > Signed-off-by: Kan Liang <kan.liang@intel.com>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Thanks, Namhyung
> --- > tools/perf/util/sort.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c > index 9402885..ee235ab 100644 > --- a/tools/perf/util/sort.c > +++ b/tools/perf/util/sort.c > @@ -1430,6 +1430,15 @@ int sort_dimension__add(const char *tok) > sort__has_parent = 1; > } else if (sd->entry == &sort_sym) { > sort__has_sym = 1; > + /* > + * perf diff displays the performance difference amongst > + * two or more perf.data files. Those files could come from > + * different binaries. So we should not compare their ips. > + * The name of symble should be the key we do compare. > + */ > + if (sort__mode == SORT_MODE__DIFF) > + sd->entry->se_collapse = sort__sym_sort; > + > } else if (sd->entry == &sort_dso) { > sort__has_dso = 1; > }
| |