Messages in this thread | | | Date | Fri, 14 Nov 2014 14:55:33 -0500 | From | Steven Rostedt <> | Subject | Re: [PATCH] printk: drop logbuf_cpu volatile qualifier |
| |
On Fri, 14 Nov 2014 13:46:44 -0600 Alex Elder <elder@linaro.org> wrote:
> On 11/14/2014 01:45 PM, Steven Rostedt wrote: > > On Fri, 14 Nov 2014 13:19:31 -0600 > > Alex Elder <elder@linaro.org> wrote: > > > >> Pranith Kumar posted a patch in which removed the "volatile" > >> qualifier for the "logbuf_cpu" variable in vprintk_emit(). > >> https://lkml.org/lkml/2014/11/13/894 > >> In his patch, he used ACCESS_ONCE() for all references to > >> that symbol to provide whatever protection was intended. > >> > >> There was some discussion that followed, and in the end > >> Stephen Rostedt concluded that not only was "volatile" not > > > > I don't know of a Stephen Rostedt. J > > Sorry. I'm sure that's a source of annoyance. -Alex
No problem. If you are wondering about that "J".
https://www.facebook.com/mcgrof/posts/10104459749108919
It's my new thing. Maybe I can start a trend. J
-- Steve
> > >> needed, neither was it required to use ACCESS_ONCE(). I > >> offered an elaborate description that concluded Stephen > > > > Who is this Stephen you talk about? > > . . .
| |