Messages in this thread | | | Subject | Re: [PATCH] HID: usbhid: get/put around clearing needs_remote_wakeup | From | Oliver Neukum <> | Date | Fri, 14 Nov 2014 10:08:30 +0100 |
| |
On Thu, 2014-11-13 at 12:16 -0800, Benson Leung wrote:
> In usbhid_open, usb_autopm_get_interface is called > before setting the needs_remote_wakeup flag, and > usb_autopm_put_interface is called after hid_start_in. > > However, when the device is closed in usbhid_close, the same > protection isn't there when clearing needs_remote_wakeup. This will > add that to usbhid_close as well as usbhid_stop.
Interesting, but this has the side effect of waking devices that are asleep just to remove the flag.
Regards Oliver
-- Oliver Neukum <oneukum@suse.de>
| |