Messages in this thread | | | Date | Thu, 13 Nov 2014 15:34:16 -0800 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH 51/56] drivers/char/mem: support compiling out splice |
| |
On Thu, Nov 13, 2014 at 02:31:50PM -0800, josh@joshtriplett.org wrote: > [Please don't top-post.] > > On Thu, Nov 13, 2014 at 11:23:46PM +0100, Pieter Smith wrote: > > Okay with moving the relevant functions to a new translation unit and > > squashing it out in the Makefile > > No, you don't need to do that either. Mark pipe_to_null and > splice_write_null as __maybe_unused, then wrap the initialization of > .splice_write = splice_write_null to make it .splice_write = > splice_p(splice_write_null). That will avoid adding a single ifdef.
Again, ick, no. You aren't saving anything "real" at all, just take out the splice core code, leave the file pointer alone, and never do that horrid "splice_p" stuff, ick ick ick.
greg k-h
| |