lkml.org 
[lkml]   [2014]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] PM / Domains: restore calling of .suspend/resume_noirq() callbacks
Hi Rafael,

On 11/13/2014 03:33 AM, Rafael J. Wysocki wrote:
> On Wednesday, November 12, 2014 06:00:47 PM Grygorii Strashko wrote:
>> Now .suspend/resume_noirq() callbacks will not be called during
>> system wide suspend/resume for devices which belongs to some GPD.
>> It seems, that this change was accidentally introduced by
>> commit d23b9b00cdde ("PM / Domains: Rework system suspend callback
>> routines (v2)").
>
> I'm not sure if that was really accidentally.
>
> Can you describe the problem that the change below is attempting to
> address, without going to much into the history? IOW, what's that
> doesn't work right now?

There are no real issues - now in Kernel there are no users of GPD
which use "noirq" callbacks.

As of now, I'm trying to use GPD for Keyatone2, so
I'm studying it and playing with it to understand all benefits and
disadvantages of such solution.

So, I've found this issue, but not found any description of why
calls of these callbacks have been removed.
I'd very appreciate if can point me on?

>
>> This patch restores calling of .suspend/resume_noirq() callbacks
>> for devices from GPD during system wide suspend/resume.
>>
>> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
>> ---
>> drivers/base/power/domain.c | 14 +++++++++++---
>> 1 file changed, 11 insertions(+), 3 deletions(-)
>>
...

Regards,
-grygorii




\
 
 \ /
  Last update: 2014-11-13 20:21    [W:0.051 / U:5.504 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site