lkml.org 
[lkml]   [2014]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ARM: b.L: fix unmet dependency for CPU_PM
On Thu, 13 Nov 2014, Pankaj Dubey wrote:

> If BL_SWITCHER is enabled but SUSPEND and CPU_IDLE is not enabled
> we are getting following config warning.
>
> warning: (BL_SWITCHER) selects CPU_PM which has unmet direct
> dependencies (SUSPEND || CPU_IDLE)
>
> So BL_SWITCHER should enable CPU_PM only if either of SUSPEND or
> CPU_IDLE is selected.
>
> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> ---
> arch/arm/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 9d580d0..fe3d969 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -1417,7 +1417,7 @@ config BL_SWITCHER
> bool "big.LITTLE switcher support"
> depends on BIG_LITTLE && MCPM && HOTPLUG_CPU
> select ARM_CPU_SUSPEND
> - select CPU_PM
> + select CPU_PM if (SUSPEND || CPU_IDLE)

NAK. You just broke the code by doing this. CPU_PM is a requirement
here. The dependencies for CPU_PM is lacking.


Nicolas


\
 
 \ /
  Last update: 2014-11-13 19:21    [W:0.221 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site