lkml.org 
[lkml]   [2014]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] perf tools: Fix ftrace:function event recording
On Thu, Nov 13, 2014 at 06:21:03PM +0100, Jiri Olsa wrote:
> Following patch fails (-EINVAL) ftrace:function with enabled user
> space callchains:
> cfa77bc4af2c perf: Disallow user-space callchains for function trace events
>
> We need to follow in perf tool itself and explicitly set the
> perf_event_attr::exclude_callchain_user flag for ftrace:function
> event.

forgot:

Reported-by: Steven Rostedt <rostedt@goodmis.org>

thanks,
jirka

>
> Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
> Cc: David Ahern <dsahern@gmail.com>
> Cc: Frederic Weisbecker <fweisbec@gmail.com>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Cc: Steven Rostedt <rostedt@goodmis.org>
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> ---
> tools/perf/util/evsel.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
> index ec5eb8033296..a3baaa31231e 100644
> --- a/tools/perf/util/evsel.c
> +++ b/tools/perf/util/evsel.c
> @@ -658,6 +658,14 @@ void perf_evsel__config(struct perf_evsel *evsel, struct record_opts *opts)
> attr->mmap_data = track;
> }
>
> + /*
> + * We don't allow user space callchains for function trace
> + * event, due to issues with page faults while tracing page
> + * fault handler and its overall trickiness nature.
> + */
> + if (perf_evsel__is_function_event(evsel))
> + evsel->attr.exclude_callchain_user = 1;
> +
> if (callchain_param.enabled && !evsel->no_aux_samples)
> perf_evsel__config_callgraph(evsel);
>
> --
> 1.9.3
>


\
 
 \ /
  Last update: 2014-11-13 19:01    [W:0.036 / U:0.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site