lkml.org 
[lkml]   [2014]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mm/zram: correct ZRAM_ZERO flag bit position
On (11/12/14 22:37), Mahendran Ganesh wrote:
> In struct zram_table_entry, the element *value* contains obj size and
> obj zram flags. Bit 0 to bit (ZRAM_FLAG_SHIFT - 1) represent obj size,
> and bit ZRAM_FLAG_SHIFT to the highest bit of unsigned long represent obj
> zram_flags. So the first zram flag(ZRAM_ZERO) should be from ZRAM_FLAG_SHIFT
> instead of (ZRAM_FLAG_SHIFT + 1).
>
> This patch fixes this issue.

well, I wouldn't say this is an issue; but still.

Acked-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>

-ss

> Also this patch fixes a typo, "page in now accessed" -> "page is now accessed"
>
> Signed-off-by: Mahendran Ganesh <opensource.ganesh@gmail.com>
> ---
> drivers/block/zram/zram_drv.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/block/zram/zram_drv.h b/drivers/block/zram/zram_drv.h
> index c6ee271..b05a816 100644
> --- a/drivers/block/zram/zram_drv.h
> +++ b/drivers/block/zram/zram_drv.h
> @@ -66,8 +66,8 @@ static const size_t max_zpage_size = PAGE_SIZE / 4 * 3;
> /* Flags for zram pages (table[page_no].value) */
> enum zram_pageflags {
> /* Page consists entirely of zeros */
> - ZRAM_ZERO = ZRAM_FLAG_SHIFT + 1,
> - ZRAM_ACCESS, /* page in now accessed */
> + ZRAM_ZERO = ZRAM_FLAG_SHIFT,
> + ZRAM_ACCESS, /* page is now accessed */
>
> __NR_ZRAM_PAGEFLAGS,
> };
> --
> 1.7.9.5
>


\
 
 \ /
  Last update: 2014-11-13 16:21    [W:0.050 / U:5.668 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site