Messages in this thread | | | Date | Thu, 13 Nov 2014 21:55:56 +0800 | Subject | Re: [PATCH] mm/zswap: unregister zswap_cpu_notifier_block in cleanup procedure | From | Ganesh Mahendran <> |
| |
2014-11-13 10:53 GMT+08:00 Seth Jennings <sjennings@variantweb.net>: > On Sun, Nov 09, 2014 at 07:22:23PM +0800, Mahendran Ganesh wrote: >> In zswap_cpu_init(), the code does not unregister *zswap_cpu_notifier_block* >> during the cleanup procedure. > > This is not needed. If we are in the cleanup code, we never got to the > __register_cpu_notifier() call.
Yes, you are right. Thanks for you review.
> > Thanks, > Seth > >> >> This patch fix this issue. >> >> Signed-off-by: Mahendran Ganesh <opensource.ganesh@gmail.com> >> --- >> mm/zswap.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/mm/zswap.c b/mm/zswap.c >> index ea064c1..51a2c45 100644 >> --- a/mm/zswap.c >> +++ b/mm/zswap.c >> @@ -404,6 +404,7 @@ static int zswap_cpu_init(void) >> cleanup: >> for_each_online_cpu(cpu) >> __zswap_cpu_notifier(CPU_UP_CANCELED, cpu); >> + __unregister_cpu_notifier(&zswap_cpu_notifier_block); >> cpu_notifier_register_done(); >> return -ENOMEM; >> } >> -- >> 1.7.9.5 >>
| |