lkml.org 
[lkml]   [2014]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] fuse: don't check for file->private_data on open().
From
Date
Am 13. November 2014 11:53:29 MEZ, schrieb Miklos Szeredi <miklos@szeredi.hu>:
>On Thu, Nov 13, 2014 at 11:05 AM, Martin Kepplinger <martink@posteo.de>
>wrote:
>
>> In this week's -next this should have changed. My SSD broke down so i
>have to delay further work for a few days, i'm sorry.
>
>Please be more careful with such patches. Have you audited all of the
>(ca. 200) misc drivers? If not, this might be a good time to do so.
>If it turns out to be too much, then consider not doing the change.
>The gain might not be worth the cost.
>
>NACK in this form.
>
>Thanks,
>Miklos

Definitely should have been more careful as I checked fs too late now. I totally unnecessarily broke -next.

But If fuse-devel is ok with a fix like the one i sent (still has to get tested too) i believe we're covered. I still call for independent review though.
--
Martin Kepplinger
http://martinkepplinger.com
sent from mobile


\
 
 \ /
  Last update: 2014-11-13 12:41    [W:1.683 / U:0.508 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site