Messages in this thread | | | Date | Thu, 13 Nov 2014 01:18:31 +0100 | From | Wolfram Sang <> | Subject | Re: [PATCH] i2c: i2c-xiic: Fix big-endian register access |
| |
On Mon, Oct 13, 2014 at 06:08:47PM +0200, Thomas Gessler wrote: > The driver tried to access device registers with the (little-endian) > iowrite/ioread functions. While this worked on little-endian machines > (e.g. Microblaze with AXI bus), it made the driver unusable on > big-endian machines (e.g. PPC405 with PLB). > > During the probe function, the driver tried to write a 32-bit reset mask > into the reset register. This caused an error interrupt on big-endian > systems, because the device detected an invalid (byte-swapped) reset > mask. The result was an Oops. > > The patch implements an endianness detection similar to the one used in > other Xilinx drivers like drivers/spi/spi-xilinx.c. It was tested on a > PPC405/PLB system. > > Signed-off-by: Thomas Gessler <Thomas.Gessler@exp2.physik.uni-giessen.de>
Applied to for-next, thanks!
[unhandled content-type:application/pgp-signature] | |