[lkml]   [2014]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] mm/zram: correct ZRAM_ZERO flag bit position
On Wed, Nov 12, 2014 at 10:37:18PM +0800, Mahendran Ganesh wrote:
> In struct zram_table_entry, the element *value* contains obj size and
> obj zram flags. Bit 0 to bit (ZRAM_FLAG_SHIFT - 1) represent obj size,
> and bit ZRAM_FLAG_SHIFT to the highest bit of unsigned long represent obj
> zram_flags. So the first zram flag(ZRAM_ZERO) should be from ZRAM_FLAG_SHIFT
> instead of (ZRAM_FLAG_SHIFT + 1).
> This patch fixes this issue.
> Also this patch fixes a typo, "page in now accessed" -> "page is now accessed"
> Signed-off-by: Mahendran Ganesh <>
Acked-by: Minchan Kim <>

To be clear about "fixes this issue", it's not a bug but just clean up
so it doesn't change any behavior.


Kind regards,
Minchan Kim

 \ /
  Last update: 2014-11-13 01:41    [W:0.052 / U:32.460 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site