lkml.org 
[lkml]   [2014]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] clk: rockchip: ensure HCLK_VIO2_H2P and PCLK_VIO2_H2P stay enabled
    From
    Hi,

    On Wed, Nov 12, 2014 at 1:38 PM, Dmitry Torokhov <dtor@chromium.org> wrote:
    > Currently there is no driver owning these clocks and they have to stay
    > up for the system to function properly, so let's mark them as
    > CLK_IGNORE_UNUSED.
    >
    > Without this patch we have trouble with suspend/resume and we have
    > trouble turning the eDP back on if it ever idles off.
    >
    > Signed-off-by: Doug Anderson <dianders@chromium.org>
    > Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
    > ---
    > drivers/clk/rockchip/clk-rk3288.c | 4 ++--
    > 1 file changed, 2 insertions(+), 2 deletions(-)

    I'm already on the signed-off-by (mostly because I tweaked the commit
    message and tested this), but in case anyone cares I have reviewed
    this and tested it. ;)

    ...obviously we want to get to the bottom of the right way to handle
    all of these clocks, but since we _just_ removed the blanket "leave
    all clocks enabled" adding a few clocks back into the fold seems sane
    until we get all our ducks in a row.

    Reviewed-by: Doug Anderson <dianders@chromium.org>
    Tested-by: Doug Anderson <dianders@chromium.org>


    \
     
     \ /
      Last update: 2014-11-12 23:21    [W:2.647 / U:1.112 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site