Messages in this thread Patch in this message | | | From | Martin Kepplinger <> | Subject | [PATCH] btrfs: Don't check for file->private_data on open(). It is set by the core. | Date | Wed, 12 Nov 2014 17:38:28 +0100 |
| |
The miscdevice core now sets file->private_data to the struct miscdevice so don't fail when this is not NULL.
Signed-off-by: Martin Kepplinger <martink@posteo.de> --- This is a question: what does this check provide and does overwriting file->private_data make any difference?
Is miscdevice's open() by the user not allowed here, if file->private_data is set?
thanks!!
fs/btrfs/ioctl.c | 4 ---- 1 file changed, 4 deletions(-)
diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c index 4399f0c..066ce41 100644 --- a/fs/btrfs/ioctl.c +++ b/fs/btrfs/ioctl.c @@ -3752,10 +3752,6 @@ static long btrfs_ioctl_trans_start(struct file *file) if (!capable(CAP_SYS_ADMIN)) goto out; - ret = -EINPROGRESS; - if (file->private_data) - goto out; - ret = -EROFS; if (btrfs_root_readonly(root)) goto out; -- 1.7.10.4
| |