lkml.org 
[lkml]   [2014]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 16/16] PCI/MSI: Enhance core to support hierarchy irqdomain
Hi Thomas,

On 12/11/14 13:43, Thomas Gleixner wrote:
> From: Jiang Liu <jiang.liu@linux.intel.com>
>
> Enhance PCI MSI core to support hierarchy irqdomain, so the common
> code can be shared across architectures.
>
> [ tglx: Extracted and combined from several patches ]
>
> Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Grant Likely <grant.likely@linaro.org>
> Cc: Marc Zyngier <marc.zyngier@arm.com>
> Cc: Yingjoe Chen <yingjoe.chen@mediatek.com>
> Cc: Yijing Wang <wangyijing@huawei.com>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> ---
> drivers/pci/Kconfig | 5 ++++
> drivers/pci/msi.c | 62 ++++++++++++++++++++++++++++++++++++++++++++++++++++
> include/linux/msi.h | 8 ++++++
> 3 files changed, 75 insertions(+)
>
> Index: tip/drivers/pci/Kconfig
> ===================================================================
> --- tip.orig/drivers/pci/Kconfig
> +++ tip/drivers/pci/Kconfig
> @@ -17,6 +17,11 @@ config PCI_MSI
>
> If you don't know what to do here, say Y.
>
> +config PCI_MSI_IRQ_DOMAIN
> + bool
> + depends on PCI_MSI
> + select GENERIC_MSI_IRQ_DOMAIN
> +
> config PCI_DEBUG
> bool "PCI Debugging"
> depends on PCI && DEBUG_KERNEL
> Index: tip/drivers/pci/msi.c
> ===================================================================
> --- tip.orig/drivers/pci/msi.c
> +++ tip/drivers/pci/msi.c
> @@ -19,6 +19,7 @@
> #include <linux/errno.h>
> #include <linux/io.h>
> #include <linux/slab.h>
> +#include <linux/irqdomain.h>
>
> #include "pci.h"
>
> @@ -1072,3 +1073,64 @@ int pci_enable_msix_range(struct pci_dev
> return nvec;
> }
> EXPORT_SYMBOL(pci_enable_msix_range);
> +
> +#ifdef CONFIG_PCI_MSI_IRQ_DOMAIN
> +void pci_msi_domain_write_msg(struct irq_data *irq_data, struct msi_msg *msg)
> +{
> + struct msi_desc *desc = irq_data->msi_desc;
> +
> + /*
> + * MSI-X message is written per-IRQ.
> + * MSI message denotes a contiguous group of IRQs, written for 0th IRQ.
> + */
> + if (desc->irq == irq_data->irq)
> + pci_write_msi_msg(desc, msg);

My compiler barks at this. Shouldn't that be either:
pci_write_msi_msg(desc->irq, msg);
or
__pci_write_msi_msg(desc, msg);
?

Thanks,

M.
--
Jazz is not dead. It just smells funny...



\
 
 \ /
  Last update: 2014-11-12 17:01    [W:0.296 / U:3.552 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site