lkml.org 
[lkml]   [2014]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: usb: gadget: midi: f_midi_alloc() can be static
On Wed, Nov 12, 2014 at 09:28:24PM +0800, Fengguang Wu wrote:
> drivers/usb/gadget/function/f_midi.c:1072:21: sparse: symbol 'f_midi_alloc' was not declared. Should it be static?
> drivers/usb/gadget/legacy/gmidi.c:118:30: sparse: symbol 'fi_midi' was not declared. Should it be static?
> drivers/usb/gadget/legacy/gmidi.c:119:21: sparse: symbol 'f_midi' was not declared. Should it be static?
>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

I'm taking this one, but next time please Cc linux-usb

> ---
> function/f_midi.c | 2 +-
> legacy/gmidi.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> Index: linux/drivers/usb/gadget/function/f_midi.c
> ===================================================================
> --- linux.orig/drivers/usb/gadget/function/f_midi.c
> +++ linux/drivers/usb/gadget/function/f_midi.c
> @@ -1069,7 +1069,7 @@ static void f_midi_unbind(struct usb_con
> usb_free_all_descriptors(f);
> }
>
> -struct usb_function *f_midi_alloc(struct usb_function_instance *fi)
> +static struct usb_function *f_midi_alloc(struct usb_function_instance *fi)
> {
> struct f_midi *midi;
> struct f_midi_opts *opts;
> Index: linux/drivers/usb/gadget/legacy/gmidi.c
> ===================================================================
> --- linux.orig/drivers/usb/gadget/legacy/gmidi.c
> +++ linux/drivers/usb/gadget/legacy/gmidi.c
> @@ -115,8 +115,8 @@ static struct usb_gadget_strings *dev_st
> NULL,
> };
>
> -struct usb_function_instance *fi_midi;
> -struct usb_function *f_midi;
> +static struct usb_function_instance *fi_midi;
> +static struct usb_function *f_midi;
>
> static int __exit midi_unbind(struct usb_composite_dev *dev)
> {

--
balbi
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2014-11-12 16:41    [W:0.033 / U:1.760 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site