[lkml]   [2014]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] regulator: core: export function to check if regulator always on
On Wed, Nov 12, 2014 at 11:35:41AM +0000, Mark Brown wrote:
> On Wed, Nov 12, 2014 at 11:18:35AM +0000, Richard Fitzgerald wrote:
> > Export a function to allow a consumer to check if its supply
> > regulator is always on. Drivers might wish to take different
> > action based on this - for example skipping time-consuming
> > power-saving preparations that are irrelevant if the regulator
> > cannot be disabled.
> I'd like to see a user here,

The user will be the Arizona codec drivers but I wanted to upstream
this patch first for discussion.

> and I'd also like to understand why this is
> a better approach than using a callback to postpone these expensive
> operations until the regulator is actually powered off like we already
> do for some things like register cache resyncs. That is normally better
> since it also avoids the work in cases where the regulator isn't always
> on like reenabling during a delayed powerdown or shared regulators.

The runtime_suspend() for the Arizona drivers has to do a bunch of
preparation before disabling the DCVDD regulator (and there's more
preparation steps that need to be upstreamed). There's no point doing
any of this if at the end the regulator isn't going to switch off.

> You're also missing a !CONFIG_REGULATOR stub.

It's there at the end of the patch, returning 1.

 \ /
  Last update: 2014-11-12 14:41    [W:0.042 / U:1.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site