lkml.org 
[lkml]   [2014]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v9 13/13] swiotlb-xen: remove BUG_ON in xen_bus_to_phys
    Date
    On x86 truncation cannot occur because config XEN depends on X86_64 ||
    (X86_32 && X86_PAE).

    On ARM truncation can occur without CONFIG_ARM_LPAE, when the dma
    operation involves foreign grants. However in that case the physical
    address returned by xen_bus_to_phys is actually invalid (there is no mfn
    to pfn tracking for foreign grants on ARM) and it is not used.

    Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
    Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
    ---
    drivers/xen/swiotlb-xen.c | 2 --
    1 file changed, 2 deletions(-)

    diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c
    index 498b654..153cf14 100644
    --- a/drivers/xen/swiotlb-xen.c
    +++ b/drivers/xen/swiotlb-xen.c
    @@ -96,8 +96,6 @@ static inline phys_addr_t xen_bus_to_phys(dma_addr_t baddr)
    dma_addr_t dma = (dma_addr_t)pfn << PAGE_SHIFT;
    phys_addr_t paddr = dma;

    - BUG_ON(paddr != dma); /* truncation has occurred, should never happen */
    -
    paddr |= baddr & ~PAGE_MASK;

    return paddr;
    --
    1.7.10.4


    \
     
     \ /
      Last update: 2014-11-12 13:21    [W:4.099 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site