lkml.org 
[lkml]   [2014]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [V2 PATCH 1/4] scsi:stex.c Support to Pegasus series.
> +	u8  yellowstone;

Calling this flag yellowstone seems a bit confusing as there already
is a st_yel card type, and this only seems a subset of those. Maybe
a ->support_pm flag or similar would be useful?

> + u32 subID;

We don't use camelCaps, but I don't think you even need this variable at
all..

>
> hba->cardtype = (unsigned int) id->driver_data;
> ci = &stex_card_info[hba->cardtype];
> + subID = id->subdevice;
> + if ((subID == 0x4221 || subID == 0x4222 ||
> + subID == 0x4223 || subID == 0x4224 ||
> + subID == 0x4225 || subID == 0x4226 ||
> + subID == 0x4227 || subID == 0x4261 ||
> + subID == 0x4262 || subID == 0x4263 ||
> + subID == 0x4264 || subID == 0x4265) &&
> + (hba->cardtype == st_yel)) {
> + hba->yellowstone = 1;
> + } else if (hba->cardtype == st_yel) {
> + hba->yellowstone = 0;
> + }

Just write this as

switch (id->subdevice) {
case 0x4221:
case 0x4222:
case 0x4223:
case 0x4224:
case 0x4225:
case 0x4226:
case 0x4227:
case 0x4261:
case 0x4262:
case 0x4263:
case 0x4264:
case 0x4265:
if (hba->cardtype == st_yel) {
hba->supports_pm = 1;
break;
}
default:
hba->supports_pm = 0;
}



\
 
 \ /
  Last update: 2014-11-12 12:21    [W:0.038 / U:1.872 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site