lkml.org 
[lkml]   [2014]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.17 005/319] vxlan: fix a use after free in vxlan_encap_bypass
    Date
    3.17-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Li RongQing <roy.qing.li@gmail.com>

    [ Upstream commit ce6502a8f9572179f044a4d62667c4645256d6e4 ]

    when netif_rx() is done, the netif_rx handled skb maybe be freed,
    and should not be used.

    Signed-off-by: Li RongQing <roy.qing.li@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/vxlan.c | 8 +++++---
    1 file changed, 5 insertions(+), 3 deletions(-)

    --- a/drivers/net/vxlan.c
    +++ b/drivers/net/vxlan.c
    @@ -1717,6 +1717,8 @@ static void vxlan_encap_bypass(struct sk
    struct pcpu_sw_netstats *tx_stats, *rx_stats;
    union vxlan_addr loopback;
    union vxlan_addr *remote_ip = &dst_vxlan->default_dst.remote_ip;
    + struct net_device *dev = skb->dev;
    + int len = skb->len;

    tx_stats = this_cpu_ptr(src_vxlan->dev->tstats);
    rx_stats = this_cpu_ptr(dst_vxlan->dev->tstats);
    @@ -1740,16 +1742,16 @@ static void vxlan_encap_bypass(struct sk

    u64_stats_update_begin(&tx_stats->syncp);
    tx_stats->tx_packets++;
    - tx_stats->tx_bytes += skb->len;
    + tx_stats->tx_bytes += len;
    u64_stats_update_end(&tx_stats->syncp);

    if (netif_rx(skb) == NET_RX_SUCCESS) {
    u64_stats_update_begin(&rx_stats->syncp);
    rx_stats->rx_packets++;
    - rx_stats->rx_bytes += skb->len;
    + rx_stats->rx_bytes += len;
    u64_stats_update_end(&rx_stats->syncp);
    } else {
    - skb->dev->stats.rx_dropped++;
    + dev->stats.rx_dropped++;
    }
    }




    \
     
     \ /
      Last update: 2014-11-12 02:41    [W:4.131 / U:0.336 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site