Messages in this thread | | | Date | Tue, 11 Nov 2014 16:25:00 -0500 (EST) | Subject | Re: [PATCH v2] usbnet: smsc95xx: dereferencing NULL pointer | From | David Miller <> |
| |
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com> Date: Tue, 11 Nov 2014 14:10:47 +0530
> we were dereferencing dev to initialize pdata. but just after that we > have a BUG_ON(!dev). so we were basically dereferencing the pointer > first and then tesing it for NULL. > > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> > --- > > change in v2: suspend_flags is initialised after pdata is initialised. > v1 had a very silly but serious mistake of making pdata NULL, and trying > to dereference it. > sorry again for that.
This looks better, applied, thanks.
| |