lkml.org 
[lkml]   [2014]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] arm: dts: zynq: Add Digilent ZYBO board
Hi,

I think you can simple use "digilent".
The first step is to send the patch with add digilent to
Documentation/devicetree/bindings/vendor-prefixes.txt

and then feel free to send patch for fixing digilent,zed
+ zybo dts.

Thanks,
Michal


On 11/11/2014 03:10 AM, Steve Wang wrote:
> Hi, Peter,
>
> According to naming convention, I think "dglnt" is good enough ^.^
>
> By the way, I think there is a need to address another issue that needs to be
> addressed for ZYBO as well (maybe in a separate thread):
> MAC address pre-load from on-board EEPROM.
> I think ZYBO might still be the only Zynq-based board that has an on-board
> EEPROM for MAC address as well.
>
> Regards,
> Steve
>
> -----Peter Crosthwaite <crosthwaitepeter@gmail.com> wrote: -----
> To: Sören Brinkmann <soren.brinkmann@xilinx.com>, Steve Wang
> <steven.wang@digilentinc.com>
> From: Peter Crosthwaite <crosthwaitepeter@gmail.com>
> Date: 11/10/2014 02:56PM
> Cc: linux-kernel@vger.kernel.org, michals@xilinx.com, sorenb@xilinx.com
> Subject: Re: [PATCH 2/2] arm: dts: zynq: Add Digilent ZYBO board
>
> On Tue, Nov 11, 2014 at 8:42 AM, Sören Brinkmann
> <soren.brinkmann@xilinx.com> wrote:
> > On Tue, 2014-11-11 at 08:39AM +1000, Peter Crosthwaite wrote:
> >> On Mon, Nov 10, 2014 at 7:47 AM, Sören Brinkmann
> >> <soren.brinkmann@xilinx.com> wrote:
> >> > Hi Peter,
> >> >
> >> > On Sun, 2014-11-09 at 01:38PM +1000, Peter Crosthwaite wrote:
> >> >> Add a DTS describing the Digilent ZYBO board. Similar to ZED but with
> >> >
> >> > "Digilent ZYBO" here...
> >> >
> >> > [...]
> >> >> +/ {
> >> >> + model = "Zynq ZYBO Development Board";
> >> >> + compatible = "xlnx,zynq-zybo", "xlnx,zynq-7000";
> >> >
> >> > ... "xlnx,zynq-zybo" here. Seems inconsistent. IMHO, there should rather be
> >> > a digilent vendor prefix.
> >> >
> >>
> >> Was going for consistency with ZED which also makes this mistake:
> >>
> >> model = "Zynq Zed Development Board";
> >> compatible = "xlnx,zynq-zed", "xlnx,zynq-7000";
> >>
> >> We have to choose between consistency and correctness. If we do fix it
> >> though, what is Diglent's four-letter vendor prefix?
> >
> > Since Digilent is the board vendor, I'm for using the appropriate
> > prefix. Vendor prefixes are found in
> > Documentation/devicetree/bindings/vendor-prefixes.txt.
> >
>
> It's not there,
>
> Steven, does Digilent have a preferred dts vendor prefix?
>
> Regards,
> Peter
>
> > Soren
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2014-11-11 09:21    [W:0.089 / U:0.932 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site