| Date | Tue, 11 Nov 2014 13:47:08 +0100 | Subject | Re: [PATCH 2/7] pinctrl: pinconf-generic: Infer map type from DT property | From | Linus Walleij <> |
| |
On Mon, Nov 3, 2014 at 8:05 PM, Soren Brinkmann <soren.brinkmann@xilinx.com> wrote:
> With the new 'groups' property, the DT parser can infer the map type > from the fact whether 'pins' or 'groups' is used to specify the pin > group to work on. > To maintain backwards compatibitliy with current usage of the DT > binding, this is only done when an invalid map type is passed to the > parsing function.
So that is this:
> + if (type == PIN_MAP_TYPE_INVALID) > + type = PIN_MAP_TYPE_CONFIGS_GROUP; > + dt_pin_specifier = "groups";
This is just kludgy. There are only two kernel-internal users of this function, refactor the function signature and change the other callers over instead, patch the drivers.
Take this opportunity to add some kerneldoc above the pinconf_generic_dt_subnode_to_map() and give the function a reasonable signature.
BTW: this is just for config settings for groups right? Not for muxing I hope?
Yours, Linus Walleij
|