lkml.org 
[lkml]   [2014]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] spi: add support for DLN-2 USB-SPI adapter
On Tue, Nov 11, 2014 at 02:38:08PM +0200, Laurentiu Palcu wrote:
> On Sat, Nov 08, 2014 at 10:46:06AM +0000, Mark Brown wrote:

> > You shouldn't need this _put(), it's defeating the purpose of having the
> > devm_ registration.

> Agreed! I used spi-rockchip.c as a template and I took it for granted.
> I'll remove this line in v2. And, if you think it's worth it, I can send
> a separate patch for spi-rockchip.c too.

Yes, please.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2014-11-11 15:01    [W:0.048 / U:2.356 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site