lkml.org 
[lkml]   [2014]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.16.y-ckt 017/170] ext4: fix mmap data corruption when blocksize < pagesize
    Date
    3.16.7-ckt1 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Jan Kara <jack@suse.cz>

    commit d6320cbfc92910a3e5f10c42d98c231c98db4f60 upstream.

    Use truncate_isize_extended() when hole is being created in a file so that
    ->page_mkwrite() will get called for the partial tail page if it is
    mmaped (see the first patch in the series for details).

    Signed-off-by: Jan Kara <jack@suse.cz>
    Signed-off-by: Theodore Ts'o <tytso@mit.edu>
    Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
    ---
    fs/ext4/inode.c | 6 +++++-
    1 file changed, 5 insertions(+), 1 deletion(-)

    diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
    index e9c9b5bd906a..14f34b02dde5 100644
    --- a/fs/ext4/inode.c
    +++ b/fs/ext4/inode.c
    @@ -4654,8 +4654,12 @@ int ext4_setattr(struct dentry *dentry, struct iattr *attr)
    ext4_orphan_del(NULL, inode);
    goto err_out;
    }
    - } else
    + } else {
    + loff_t oldsize = inode->i_size;
    +
    i_size_write(inode, attr->ia_size);
    + pagecache_isize_extended(inode, oldsize, inode->i_size);
    + }

    /*
    * Blocks are going to be removed from the inode. Wait
    --
    2.1.0


    \
     
     \ /
      Last update: 2014-11-11 15:01    [W:5.166 / U:0.632 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site