lkml.org 
[lkml]   [2014]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v8 03/13] xen/arm: if(pfn_valid(pfn)) call native dma_ops
On Mon, 10 Nov 2014, Catalin Marinas wrote:
> On Mon, Nov 10, 2014 at 04:13:55PM +0000, Stefano Stabellini wrote:
> > void xen_dma_unmap_page(struct device *hwdev, dma_addr_t handle,
> > size_t size, enum dma_data_direction dir,
> > - struct dma_attrs *attrs);
> > + struct dma_attrs *attrs)
> > +{
> > + unsigned long pfn = PFN_DOWN(handle);
> > + /* Dom0 is mapped 1:1, so calling pfn_valid on a foreign mfn will
> > + * always return false. If the page is local we can safely call the
> > + * native dma_ops function, otherwise we call the xen specific
> > + * function. */
> > + if (pfn_valid(pfn)) {
> > + if (__generic_dma_ops(hwdev)->unmap_page)
> > + __generic_dma_ops(hwdev)->unmap_page(hwdev, handle, size, dir, attrs);
>
> Similarly here, do we need the unmap_page check? dma_map_page() does not
> do it.

I think we do not need the map_page check, because that's always
implemented, but we need the unmap_page check. In fact
arm_coherent_dma_ops doesn't have unmap_page for example.


\
 
 \ /
  Last update: 2014-11-11 12:41    [W:0.059 / U:2.640 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site